-
Notifications
You must be signed in to change notification settings - Fork 4
Bug 986206 - Report filenames on test failures r=jgriffin #6
Conversation
@@ -67,7 +67,7 @@ TBPL.prototype = { | |||
*/ | |||
onFail: function(test, err) { | |||
var title = this.getTitle(test); | |||
console.log('TEST-UNEXPECTED-FAIL | %s', title); | |||
console.log('TEST-UNEXPECTED-FAIL | %s in %s', title, test.file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format should be: ('TEST-UNEXPECTED-FAIL | %s | %s', test.file, title), per https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy#6.29_Outputs_failures_in_a_TBPL-starrable_format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixing...
@jonallengriffin Updated to correct format! |
@@ -67,7 +67,7 @@ TBPL.prototype = { | |||
*/ | |||
onFail: function(test, err) { | |||
var title = this.getTitle(test); | |||
console.log('TEST-UNEXPECTED-FAIL | %s', title); | |||
console.log('TEST-UNEXPECTED-FAIL | %s | %s', title, test.file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should be test.file, then title, e.g., "TEST-UNEXPECTED-FAIL | test_foo.js | something bad happened".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohp sorry I misread!
Updated again lol |
Perfect, thanks! |
Bug 986206 - Report filenames on test failures r=jgriffin
No description provided.